News for hackers. Stuff that matters.

A comment on Goodbye, Clean Code. Parent comment

Re:Goodbye, Clean Code by labawi on Sunday January 12, 2020 @07:40AM (#22026022)
If you have a 95% match on something nontrivial (and it likely won't diverge significantly), I'd go for merging even with 2 cases. At least merge most of the common parts.

Reading a couple of ifs, and some not-quite duplicate procedures seems much better than having a complete 2-set in cross-refenenced files.

[ Parent | on HN ]
Re:Goodbye, Clean Code by scarface74 on Sunday January 12, 2020 @02:06PM (#22028387)
Why are you reading a couple of ifs instead of having the two similar things represented by separate classes with shared functionality in a common class? Or even if you prefer composition to inheritance you could still make it work cleaner without a bunch of if statements.
[ Parent | on HN ]
Re:Goodbye, Clean Code by dkersten on Sunday January 12, 2020 @09:32AM (#22026406)
With a 95% match, you really only have one use case, with some minor variation.
[ Parent | on HN ]