Re:No nuances, just buggy code (was: related to Spinlock imp...
by swfsql on Sunday January 05, 2020 @08:14AM
(#21961113)
I'd appreciate if "this code is garbage" was at the end, so it would be (and feel more like) a conclusion.
Saying that stuff at the beginning only clutters the reasoning, as one should not "just believe" that that code was "indeed garbage", just because he said so.
Re:No nuances, just buggy code (was: related to Spinlock imp...
by kelnos on Monday January 13, 2020 @07:27PM
(#22040430)
That's a fair point, and moving it to the end would likely make the whole thing read better overall, but really... it's just not necessary to include it at all. It doesn't add anything to the discussion or critique, and can only serve to detract, so why bother?
Giving someone an out is a great thing to do, especially for people for whom saving face is important. But I don't think "this code is garbage" does that. Something like, "that code is measuring timing incorrectly because X", conveys the same information without being inflammatory. "Garbage" is a value judgment, while just pointing out that it's doing something incorrectly is merely stating a fact.