News for hackers. Stuff that matters.

A comment on Show HN: A better way to review pull requests.

Re:Show HN: A better way to review pull requests by thsowers on Friday December 27, 2019 @08:43PM (#21896472)
This is a very nice interface! I wonder how well it would scale for huge PRs (many thousands of line changes), which right now are both irritating to review on Github, and other tools like IntelliJ.

Somewhat related, but I wonder if some of the bottlenecks/constraints in this area are caused by the browser or electron (think GitKraken). I know that there are some new tools out there that differ, such as Sublime Merge which uses the same engine as Sublime Text, but I haven't had a chance to try that out yet.

It may be interesting to benchmark Gitlab, Github, prhero, Sublime Merge and other tools on PRs of various sizes..

[ Parent | on HN ]
Re:Show HN: A better way to review pull requests by kodebrew on Friday December 27, 2019 @08:59PM (#21896531)
It should handle large PR's quite well. It probably doesn't right now but that's more a function of the code being hacky.

I think the problem with the GitHub UI is you have so much scrolling that it's a large amount for the browser to try and paint out and for a user to parse through. Since this is only showing a diff on a file at a time it's not subject to that issue.

[ Parent | on HN ]