Hacking GitHub's Auth with Unicode's Turkish Dotless 'I'

Re:Hacking GitHub's Auth with Unicode's Turkish Dotless 'I' by iudqnolq on Monday December 16, 2019 @11:11PM (#21810476)

I agree completely. I might do .+@.+\..+ on the frontend to catch people mixing up usernames and emails, but that's it.

You might not be surprised that regex comes from a Perl module :)

[ Parent | on HN ]

Re:Hacking GitHub's Auth with Unicode's Turkish Dotless 'I' by Avamander on Monday December 16, 2019 @11:16PM (#21810500)

To be honest, login forms should take both username and e-mail as the user identifier, far too often they don't. I personally think that the only place where such a regex should exist is during sign-up.

[ Parent | on HN ]

Re:Hacking GitHub's Auth with Unicode's Turkish Dotless 'I' by iudqnolq on Monday December 16, 2019 @11:28PM (#21810579)

Fair enough, although you could I suppose run into issues doing that retroactively if you allowed `@` in usernames...

[ Parent | on HN ]