Re:Simple Dynamic Strings library for C, compatible with nul...
by chacham15 on Tuesday December 03, 2019 @01:17PM
(#21694954)
I think you're missing the point here, the conversion function is trivially inlinable:
The other posters solution is actually not equivalent in this way (his sds is convertable to char* instead of sds*).
[ Parent
| on HN ]
Re:Simple Dynamic Strings library for C, compatible with nul...
by electrograv on Tuesday December 03, 2019 @02:33PM
(#21695787)
Even an inlined function only has value if our goal is to open the door to implementation changes in the future. But because the current implementation is zero-cost (an inlined no-op), any behavioral change will necessary compromise performance.
Otherwise (if we want to retain the zero-cost guarantee of converting to a C string), directly accessing the member variable is: functionally equivalent, simpler, more concise, more readable, more explicit.
Re:Simple Dynamic Strings library for C, compatible with nul...
by chrchang523 on Tuesday December 03, 2019 @05:08PM
(#21697340)
I actually prefer the inline function here (while making the member char* private when compiling as C++), since that mostly prevents assignment to the member variable in settings where that would not be a valid operation.
With that said, I agree that the additional verbosity is a significant drawback, and I can understand going with the slightly-less-safe option for that reason alone.
Re:Simple Dynamic Strings library for C, compatible with nul...
by electrograv on Tuesday December 03, 2019 @05:46PM
(#21697684)
Ah, that’s a good point. I’m a fan of extra safety, though we’d need to make a few extra changes to get around C’s lack of private variables: We could make the internal member instead a size_t, and cast to pointer form when needed inside the library or when converting via this inline function (which is still a no-op in terms of performance). The only major downside then remaining is perhaps syntax/verbosity, which IMO is secondary to safety.
However: If we open the discussion up to C++, then this is pretty easy to solve without any real syntactic or performance compromise: we can make a class/struct which defines implicit conversions to C strings, and disables any implicit conversions from C strings.
Re:Simple Dynamic Strings library for C, compatible with nul...
by chrchang523 on Wednesday December 04, 2019 @11:37AM
(#21703697)
Good point about implicit conversions; I may actually be able to use that to clean up some code in the near future.