Personally I'd rather experience living somewhere in Europe for a year or two. See if you can pull that off.

Certainly no harm done living in NYC for two years especially if you come with a job lined up. It will definitely make you a bit more street smart and more adaptable, I think. As far as settling down permanently and raising a family, nope.

One good thing is that living in NYC, for the first time I didn't feel like a minority. It's so different to most of the rest of the US. There is no majority "in charge" of the place. I think that was an important experience for me.

I don't regret living there, but I wish I left sooner.

Edit: if your career is, and always will be, extremely important to you, and you have a good position with lots of potential to move up, and you are workaholic type, you will probably love it.

I lived in Oakland (and commuted into SF for work) for a year and a half so I feel like I'm pretty street smart as it is

What's the draw of Europe? Personally I don't think I'd like being a foreigner and not having any friends there. Might be cool to visit for a month or two but 2 years is kinda.... stretching it? At least in NYC its still in the states