Re:Improving Go code: An introduction to the static analysis...
by henvic on Monday November 11, 2019 @04:52AM
(#21503400)
Thanks! I've switched jobs six months ago. Previously, I worked moslty solo and relied on staticcheck and other static analysis tools a lot. On this new job I quickly found out we weren't using any tools, and staticcheck was the one I missed the most. Fortunately I was able to show its value, and we are steadily improving our codebase thanks to it.
Re:Improving Go code: An introduction to the static analysis...
by dgellow on Monday November 11, 2019 @05:55AM
(#21503742)
golangci-lint is just awesome. We started enabling it on all our repositories in combination with https://github.com/reviewdog/action-golangci-lint to have Github check warnings integration directly in the PR diff.
Also, it is now available as a choice of Go linter in Visual Studio Code.
Re:Improving Go code: An introduction to the static analysis...
by ainar-g on Monday November 11, 2019 @02:18AM
(#21502838)
Staticcheck is inavluable, and I support it with words, actions, and
money. Here are some additional tools that you might want to have in
your module's tools.go:
* github.com/kisielk/errcheck[1]: Find cases where you (accidentally?)
ignore errors.
* github.com/gordonklaus/ineffassign[2]: Find ineffectial assignments;
sounds simple, almost unneeded, but in my practice it's actually one
of the most effective analyses to find actual bugs.
* mvdan.cc/unparam[3]: Find functions that always consume or return one
value; great for refactorings.
This and also gosec are invaluable!
Something I looked recently and should adopt soon: https://github.com/golangci/golangci-lint
So far, this is what my 'de facto' lint list looks like:
echo "Checking for unchecked errors." errcheck $(go list ./...) echo "Linting code." test -z "$(golint `go list ./...` | tee /dev/stderr)" echo "Examining source code against code defect." go vet $(go list ./...) go vet -vettool=$(which shadow) echo "Running staticcheck toolset https://staticcheck.io" staticcheck ./... echo "Checking if code contains security issues." # TODO(henvic) fix/update gosec when available: # G104: Doesn't understand _ assignments #270 # https://github.com/securego/gosec/issues/270 # Ignoring G104: Audit errors not checked for now. gosec -quiet -exclude G104 --quiet ./...
Also, it is now available as a choice of Go linter in Visual Studio Code.
* github.com/kisielk/errcheck[1]: Find cases where you (accidentally?) ignore errors.
* github.com/gordonklaus/ineffassign[2]: Find ineffectial assignments; sounds simple, almost unneeded, but in my practice it's actually one of the most effective analyses to find actual bugs.
* mvdan.cc/unparam[3]: Find functions that always consume or return one value; great for refactorings.
[1] https://github.com/kisielk/errcheck
[2] https://github.com/gordonklaus/ineffassign
[3] https://github.com/mvdan/unparam
I remember trying to integrate it with code climate's tooling but for some reason or another I didn't manage to.
[1] https://github.com/alexkappa/codeclimate-staticcheck