Re:Bypassing GitHub's OAuth Flow with a Head Request
by michaelmior on Thursday November 07, 2019 @01:30PM
(#21475872)
HEAD isn't turned into GET, it's routed the same as a GET request. If it were actually turned into a GET request, then `request.get?` would have been true, and this exploit wouldn't have happened.
But I do agree with your point that routing of HEAD requests should be explicit.
Re:Bypassing GitHub's OAuth Flow with a Head Request
by homakov on Thursday November 07, 2019 @03:44PM
(#21477067)
> HEAD isn't turned into GET, it's routed the same as a GET request
Pardon my poor wording indeed, I intended to mean this too.
Re:Bypassing GitHub's OAuth Flow with a Head Request
by ptoomey3 on Thursday November 07, 2019 @05:46PM
(#21478096)
Rails actually did turn the HEAD into a GET back when this code was written - https://github.com/rails/rails/blob/e17e25cd23e8abd45b170646...
It absolutely should. Nobody expected Rails to covertly turn HEAD into GET. It must be explicit "get_or_head" method in routes.rb