Re:Code Health: Respectful Reviews == Useful Reviews
by pytester on Thursday November 07, 2019 @12:16PM
(#21475065)
>Of course you should be respectful in a code review
It seems self evident but there are a lot of people who don't believe this and take a kind of perverse pride in "tearing others' code to shreds" so it's worth enshrining in policy if nothing else.
Re:Code Health: Respectful Reviews == Useful Reviews
by svaha1728 on Thursday November 07, 2019 @12:30PM
(#21475195)
Working in various companies I have seen code reviews become filled with micro-aggressions and outright nastiness. Code reviews have a purpose but that often gets clouded in personal judgements. This ends up making things like refactoring difficult, as people just don’t want to bother with the process.
Re:Code Health: Respectful Reviews == Useful Reviews
by Japhy_Ryder on Thursday November 07, 2019 @12:55PM
(#21475484)
I agree. Really poorly done - I'm surprised this is on the front page of HN.
Re:Code Health: Respectful Reviews == Useful Reviews
by DoofusOfDeath on Thursday November 07, 2019 @04:22PM
(#21477428)
Perhaps, but I'm finding that the resulting discussion surfaces a lot of wisdom, good ideas, and different perspectives.
Re:Code Health: Respectful Reviews == Useful Reviews
by tstrass on Thursday November 07, 2019 @12:26PM
(#21475161)
I agree the examples are bad. An article like this would be really helpful with more and better examples.
Re:Code Health: Respectful Reviews == Useful Reviews
by jrochkind1 on Thursday November 07, 2019 @05:14PM
(#21477891)
What do you think are bad about the examples? They all seem reasonable to me.
The examples they give are just bad.