I either don't understand the scenario you are describing or I don't understand the failure mode you mention?
I normally don't pay much attention to whether a message is being sent out over iMessage or SMS, and less technical folks probably pay even less, so it's a bad situation when those two methods end up going to different people.
That said, I'm actually not sure what the best behavior for iOS would be here - I get that they want to use the "best" transport and send over iMessage rather than SMS if it's available. Ideally there would be some kind of warning if the phone number I have in my contacts doesn't match the one on the device that's going to receive the message, but that seems finicky as well (what if I only have their land-line?).
For awhile, at least at the Apple store, they were very deliberate about disabling "Find my iPhone" and iMessage when handing off or wiping a phone. I don't remember them doing this recently, so I figured it was built into the process now.
I do think we need some basic awareness about digital devices, just like people do when they let someone borrow the keys to their house (although, many people are terrible at managing that). I recently sold a house with a Nest and a few other IoT things. I wiped them and reset them to factory settings. The realtor and new owner were asking me for my login/password (I'm sure this happens often for them) because they figured it was still tied to my old account.
iMessage was launched in 2011 and archive.org shows that page first showing up in late 2014. I remember hearing very few options for removing your old phone early on.
It's really not up to Apple to enforce whether you use your one Apple ID with multiple devices.
This person doesn't use their Apple ID for communication, because they have an Android phone. They probably purchased an iPhone for their child and set up the Apple ID using their email address. So to clarify, they weren't using their Apple ID with multiple devices, they just set up their child's Apple ID using their email address.
I'm not trying to slam Apple here, it's a complicated issue. I'm just saying that through a sequence of pretty reasonable steps we ended up in a situation where I was texting a colleague's daughter. Fortunately they were about parking my car, but it was pretty weird regardless.
edit: I guess they may use their Apple ID on their laptop as well, so it is on multiple devices. I just don't think they use it for iMessage.
I recently sent an iMessage and got a "who is this?" response. Turns out the message went to one of their family members.
I guess they shouldn't be sharing an Apple ID, but I don't think it's a super crazy thing to do among family members (e.g. a parent who provides a phone for their child), and having private text messages go to the wrong person seems like a pretty bad failure mode.