News for hackers. Stuff that matters.
Re:Free Wordpress themes coming with a price by RBr on Saturday January 22, 2011 @03:33PM (#2131012)
Wordpress themes aren't the only ones guilty of this. Shady plugins also contain hidden code.

http://www.themelab.com/2009/12/08/stop-downloading-wordpres...

TAC (Theme Authenticity Checker) isn't a bad place to start searching for malicious code: http://builtbackwards.com/projects/tac/

However, the only real solution to this problem is to run a limited set of extremely trustworthy plugins and build your own themes.

Re:Free Wordpress themes coming with a price by shadowpwner on Saturday January 22, 2011 @04:46PM (#2131154)
> However, the only real solution to this problem is to run a limited set of extremely trustworthy plugins and build your own themes.

What on earth? It's pretty simple to check for malicious Javascript or PHP code in a theme.

Re:Free Wordpress themes coming with a price by kaerast on Saturday January 22, 2011 @07:14PM (#2131426)
It is fairly simple to check for obviously malicious JS or PHP code in a theme, but it's not so easy to find themes which are badly written and thus insecure. Can you always spot a XSS or SQL injection vulnerability?
Re:Free Wordpress themes coming with a price by jarek on Saturday January 22, 2011 @06:29PM (#2131339)
What is your exhaustive definition of "malicious" in this case?
Re:Free Wordpress themes coming with a price by shadowpwner on Saturday January 22, 2011 @07:07PM (#2131415)
Let's see:

1) Anything linked outside of the domain. 2) Anything not HTML/CSS/image/Wordpress tag/Javascript libraries 3) Anything encrypted.

Let me know if I missed anything.

Re:Free Wordpress themes coming with a price by jarek on Saturday January 22, 2011 @11:28PM (#2131783)
Do you whitelist the Javascript libraries? Who certifies them? Is having a base64 decode function available from the library a problem?

Do you scan the CSS for url() references outside of the domain?

Re:Free Wordpress themes coming with a price by shadowpwner on Sunday January 23, 2011 @03:33PM (#2133262)
1. Most Wordpress theme developers use popular Javascript libraries, so it wouldn't be too difficult to replace them with the original if you suspected something was amiss. The function wouldn't be a problem, if there wasn't any base64 code. 2. url() references should all be relative, in the same domain, so if it linked on the outside, I'd change it.

Most of the time I use a Wordpress theme as a starting point, rewriting some parts and looking over all of the code.

Also, mentioned above, securing the theme against injections and XSS is important.

Re:Free Wordpress themes coming with a price by jarek on Sunday January 23, 2011 @04:47PM (#2133421)
Do you scan images provided with the theme to check if any subset or combination of subsets of their contents can be malicious when base64 decoded?
Re:Free Wordpress themes coming with a price by RBr on Sunday January 23, 2011 @09:06AM (#2132411)
I wonder how many people who run WordPress think it's pretty simple to check for malicious Javascript or PHP code in a theme?