News for hackers. Stuff that matters.
Re:V8 adds support for top-level await by esprehn on Wednesday September 25, 2019 @12:25AM (#21067592)
The ordering is specified left to right.

  totalSize += await getSize()
becomes

  totalSize = totalSize + await getSize()
So all the map callbacks run one by one, read totalSize as 0, and then suspend waiting for getSize(). Each one then resolves and assigns totalSize to be 0 + the size.

The race is what order the getSize() calls return in since only the last one will control the return value. Otherwise the issue isn't a race but just a logical ordering bug.

(This isn't super different than doing array[two()] = one() since two will actually run first, so ex. array[i += 1] = i will modify i before assigning the value.)

Correct would be to change the body of the map to:

  const fileSize = await file.getSize();
  totalSize += fileSize;
or the whole function to:

  async function totalSize(fol) {
    const files = await fol.getFiles();
    const sizes = await Promise.all(files.map(file => file.getSize()));
    return sizes.reduce((totalSize, size) => totalSize + size, 0);
  }
Re:V8 adds support for top-level await by evmar on Wednesday September 25, 2019 @01:02AM (#21067758)
Wow, why would you define it this way. I had to check the spec because I didn't believe you. They got #2/#3 backwards.

https://es5.github.io/#x11.13.2

Re:V8 adds support for top-level await by XCSme on Wednesday September 25, 2019 @04:54AM (#21068966)
What if you change it to

  totalSize = await file.getSize() + totalSize; 
Would it be fine then?