News for hackers. Stuff that matters.

A comment on How to do a code review. Parent comment

Re:How to do a code review by jsolson on Friday September 06, 2019 @10:22AM (#20895865)
> This is a professional procedure in a professional setting, not warm words from an encouraging teacher at school...

Citing a good practice in someone's code as "yes, please do more of this" alongside "don't do this please" is not, in my opinion, fluff.

> I don't want to have to go through comments that do not add any value to the exercise of finding issues, and I have never seen people leave such comments in 20 years.

So only pay attention to unresolved comments?

[ Parent | on HN ]
Re:How to do a code review by mytailorisrich on Friday September 06, 2019 @10:30AM (#20895932)
> Citing a good practice in someone's code as "yes, please do more of this"

That simply isn't the purpose of a code review.

Good practices should be documented externally, so you can check them consistently during code review ;) It's also quite useful to have a checklist when doing a code review.

[ Parent | on HN ]