News for hackers. Stuff that matters.
Re:How to do a code review by kccqzy on Friday September 06, 2019 @01:02AM (#20893214)
Does Google really practice what they preach though?

Just recently I was looking at Angular, Google's web frontend framework. Services, modules, directives, angular-specific markup. Coming from React, I find this grossly over-engineered.

Re:How to do a code review by iamchrisle on Friday September 06, 2019 @02:09AM (#20893455)
Googler here.

In general, yes we do practice it. They are guidelines, not rules tho.

Is Angular grossly over-engineered? Depends on how you look at it.

Any code's complexity reflects the complexity of its use case and Angular, for example, needs to fit A LOT of use cases at Google. So yea, sometimes, I think it can be a big hammer for a small nail. In other cases, all that abstraction helps. I guess that's the nature of how code eventually matures over time.

Re:How to do a code review by kortilla on Friday September 06, 2019 @02:21AM (#20893508)
> I guess that's the nature of how code eventually matures over time.

Not really. It’s a sign of too many responsibilities being given to one project. Feature bloat is a real thing.

As code matures it shouldn’t be getting more and more abstraction and APIs, it should be stabilizing with fewer changes. If the former is happening, it’s a sign it needs to be broken into multiple projects.

Re:How to do a code review by dgellow on Friday September 06, 2019 @03:57AM (#20893862)
> If the former is happening, it’s a sign it needs to be broken into multiple projects.

Breaking something in smaller projects also has its own associated costs.

Re:How to do a code review by Nimitz14 on Friday September 06, 2019 @09:39AM (#20895502)
Yeah, based on my experience with android and tensorflow they fail spectacularly at it.
Re:How to do a code review by jf22 on Friday September 06, 2019 @01:22PM (#20897615)
React does must less than Angular...