How to do a code review

Re:How to do a code review by jorblumesea on Friday September 06, 2019 @12:49AM (#20893156)

That's kinda funny, because their interviews are exactly the opposite. Toy problems you'd never see in the real world, crazy abstracted solutions, O(n) demands, almost encyclopedic knowledge of data structures and algos.

Do as I say, not as I do I guess.

[ Parent | on HN ]

Re:How to do a code review by Shaanie on Friday September 06, 2019 @02:21AM (#20893505)

I suppose you just wanted to complain, but in case you're serious: interviews and code reviews fulfill entirely different purposes. Choosing the right data structure may or may not be over-engineering, it depends on the application.

Google absolutely want developers that are capable of over-engineering.

[ Parent | on HN ]

Re:How to do a code review by kortilla on Friday September 06, 2019 @02:23AM (#20893516)

>are capable of over-engineering.

Anyone can over-engineer. It’s not a compliment nor a desirable quality.

[ Parent | on HN ]

Re:How to do a code review by jorblumesea on Friday September 06, 2019 @11:43AM (#20896650)

> Google absolutely want developers that are capable of over-engineering.

Why, so, when they get on the job, they need to be told not to over-engineer?

[ Parent | on HN ]

Re:How to do a code review by username90 on Friday September 06, 2019 @02:18AM (#20893492)

Making code execute efficiently is not over-engineering, it is saving many millions of dollars and often a requirement to even launch.

[ Parent | on HN ]