News for hackers. Stuff that matters.
Re:How to do a code review by siquick on Thursday September 05, 2019 @10:28PM (#20892531)
I'm sure we've all worked in places where a senior would not like it if a junior reviewed their code, regardless of the juniors intent. But yes, always a tonne to learn.

IMO the first few code reviews should be done face to face so some rapport can be built. Receiving feedback from a 'human' is far easier to process than a faceless Github profile picture.

Re:How to do a code review by dgellow on Friday September 06, 2019 @04:08AM (#20893900)
The face to face is definitely a good approach for first reviews. Also it’s worth starting with lower expectations and less critical feedbacks then increase over time. It takes time for people to feel comfortable receiving direct critics from persons they aren’t familiar to.