Re:How to do a code review
by derekp7 on Thursday September 05, 2019 @10:06PM
(#20892414)
There are often multiple ways to make a make a skinny cat, with no particular way better in all respects than any other method. Programmers end up designing code based on their own mental model, held in their head at that time, and would not really be able to explain that model to someone else. That someone else in turn has a different mental model of what is the correct way. Both ways are correct, just one of them is not what the reviewer would have done.
When the reviewer communicates this to the coder, this often comes across as criticism of code that is in reality perfectly fine.
When the reviewer communicates this to the coder, this often comes across as criticism of code that is in reality perfectly fine.