I should correct myself and say that Analogies are "Overused". Feynman's teaching style had frequent use of Analogies but as a way to clarify the concept, not manifest the concept using an analogy in a didactic manner to students. He explained things in plain english first.

Analogies definitely have a place in learning but it should be carefully prefaced with a warning that analogies can only go so far. You can't explain Quantum Electrodynamics using analogies or you're misleading the students.