WhatsApp, though, is still owned by Facebook and, therefore, has all kinds of privacy concerns. Last I heard, the encryption wasn't e2e and used a key that was generated by the app. If that's the case, then Facebook has a copy of that key.

The key has to be generated either in the app or on some server. There are no other choices really, unless you use only ephemeral keys - and that gives you secrecy but doesn't validate the other side. (And you can still copy that key) WhatsApp is e2e on all devices since 2016 and uses open whisper, which is the same encryption as signal.

Regarding the key - you have to trust the app it doesn't share it with the app authors. That's regardless of who/how implements the encryption. And it's true for iMessage as well.

>it's true for iMessage as well

Are you sure about that? I was under the impression that, according to the security white paper released by Apple, that the key is generated on-device in the Secure Enclave and that Apple never has access to it. The Enclave itself also doesn't have network access so there's no way for that to be transmitted anywhere by any other means except for physical access, which is also limited in the hardware.

You still have to trust the app to use the secure enclave and not generate the key in standard code.

iMessage does that, though. This has been verified by the jailbreak community and the netsec community.