Re:Things I Learnt from a Senior Software Engineer
by rakamotog on Sunday August 25, 2019 @11:47PM
(#20797334)
The only time I (a PM) would do this is when you are working on validation messages / error messages / user facing text.
[ Parent
| on HN ]
Re:Things I Learnt from a Senior Software Engineer
by afarrell on Monday August 26, 2019 @02:53AM
(#20797944)
Error message phrasing is really very important, but it’s probably better to have that refined in code review or to have some explicit step for it.
Re:Things I Learnt from a Senior Software Engineer
by dotancohen on Monday August 26, 2019 @04:31AM
(#20798227)
Error message phrasing should not be in code. It should be in localization files, even for the default language, and not require a developer to modify.
Re:Things I Learnt from a Senior Software Engineer
by SamuelAdams on Monday August 26, 2019 @08:30AM
(#20799275)
Depends on the requirements. I've had many internal-only applications only require one language: English. At that point you can hard code many things, which skips the loading other files, checking different languages, etc.
Re:Things I Learnt from a Senior Software Engineer
by OJFord on Monday August 26, 2019 @01:03PM
(#20801554)
I'd still rather the exact wording isn't in code, personally:
get_msg('fail_add_address')
vs. 'I\'m sorry, we\'ve been unable to add the address %s at this time,' \
' please try again later.'
(... but that's an ideal I have without ever having worked with it, so what do I know, and ymmv, etc.)
Re:Things I Learnt from a Senior Software Engineer
by rakamotog on Tuesday August 27, 2019 @09:54AM
(#20809570)
And what is this localization file called?
We do not have a system where non dev can commit any change in our product.
We do have a constants file which has all the messages but a PM does not access to code/commit and has to go via a Dev.
Re:Things I Learnt from a Senior Software Engineer
by rmetzler on Monday August 26, 2019 @11:43AM
(#20800751)
It really depends on who‘s the target group. I hate localization in Developer Tools etc, because googling it is harder and a lot of times English is just easier to understand. It’s different for a shopping site.
Re:Things I Learnt from a Senior Software Engineer
by high_derivative on Monday August 26, 2019 @07:29AM
(#20798917)
How would you know this without entering their personal space?