Re:A bug I wish I hadn't caught
by debaserab2 on Thursday August 15, 2019 @10:48AM
(#20705674)
How can you know that there's no sanitization just from this blog post?
[ Parent
| on HN ]
Re:A bug I wish I hadn't caught
by MichaelApproved on Thursday August 15, 2019 @11:03AM
(#20705830)
I think OP is getting the wrong idea from the screen shot in the article. There's a pic of an SQL query being run from a terminal. They might be thinking that it's a screen shot from the actual code.
Re:A bug I wish I hadn't caught
by aloknnikhil on Thursday August 15, 2019 @11:37AM
(#20706130)
It's open source.
https://github.com/RoganMurley/Ring-of-Worlds/blob/master/se...
This looks perfectly fine? Are you referring to the fact that they don't escape special characters like ' in the string? With the proper interfaces, like using prepared statements (which this likely uses in the backend, if this is an actual SQL db), instead of putting queries together just by concatenating strings, escaping strings is not only unnecessary but actively harmful.
Re:A bug I wish I hadn't caught
by aloknnikhil on Thursday August 15, 2019 @11:39AM
(#20706140)
https://github.com/RoganMurley/Ring-of-Worlds/blob/master/se...
It's all open source
Re:A bug I wish I hadn't caught
by dwohnitmok on Thursday August 15, 2019 @11:55AM
(#20706317)
It looks properly sanitized to me. The DB library being used is creating prepared SQL statements underneath the hood.