News for hackers. Stuff that matters.
Re:Open Source Contribution Etiquette by ScottBurson on Friday December 31, 2010 @04:25PM (#2056506)
Wow, I had never heard of someone doing major reformatting, reorganizing, or refactoring on someone else's code before submitting a patch! I would say that anyone who would do such a thing doesn't understand what it means to work with other people!
Re:Open Source Contribution Etiquette by knieveltech on Friday December 31, 2010 @05:03PM (#2056585)
It happens although I'd like to believe it's rare. I perpetrated the most glaring example of patch refactoring I've ever seen.

The scenario: - Original maintainer's module code totally ignored the code style conventions for the larger project it was a part of. - Module maintainer had been dragging heels on a raft of bugfixes, module stuck in beta limbo for six months. - Boss says we need this feature (cleaned up and stable) in our codebase by the end of the month.

My play: I refactored the codebase to meet larger project coding style standards, patched every bug in the issue queue, added a suite of unit tests and submitted the entire thing back to the maintainer.

Maintainer's play: The maintainer opted to reject my patch on the grounds he preferred his personal coding style to the project standards.

Endgame: I promptly re-rolled the patch as an addition to another related module, got the code committed to that project, posted an issue to the original maintainer's queue indicating his module was deprecated. Last time I checked in dude's module was still buggy and he was taking flack from several people involved with the larger project for being a cowboy with the coding standards.

Re:Open Source Contribution Etiquette by jcapote on Saturday January 01, 2011 @12:18AM (#2057267)
Yea neither have I, that's crazy. I try to make my patches as small as possible (makes it easier to merge as well)
Re:Open Source Contribution Etiquette by dasil003 on Saturday January 01, 2011 @01:38PM (#2058038)
Yeah, I'm not denying it happens, but it seems like common sense to me. The type of programmer inclined to refactor and rename should be the first to recognize the value of uniform coding conventions within a project.