Re:Tips for reviewing code you don’t like
by slavik81 on Monday July 08, 2019 @12:17PM
(#20383960)
It's fine for a review to be passive. The review is about the code, not the person who wrote it.
When the reviewer prescribes a solution, it requires the author to push back if they want to solve the issue differently. For example, if they noticed they could delete the variable rather than align it.
Though, I'm used to code reviews where the author and reviewer are both professionals and equals. I suppose if the author is an unknown person submitting a patch, you might want to rely less on their professional judgement.
When the reviewer prescribes a solution, it requires the author to push back if they want to solve the issue differently. For example, if they noticed they could delete the variable rather than align it.
Though, I'm used to code reviews where the author and reviewer are both professionals and equals. I suppose if the author is an unknown person submitting a patch, you might want to rely less on their professional judgement.