Indeed, replacing this with the list of top 100 passwords would be much more effective.
Or, alternatively, switching to the haveibeenpwned API[1] or zxcvbn[2].
[1]: https://haveibeenpwned.com/API/v2 [2]: https://github.com/dropbox/zxcvbn
It seems to do that too (comparing against a list of the top 500 passwords):
https://github.com/bdmac/strong_password/blob/master/lib/str...
Re:Strong_password Rubygem hijacked
by senorprogrammer on Sunday July 07, 2019 @10:11PM
(#20379407)
A long time ago I made a gem that does pretty much this: https://github.com/senorprogrammer/pil
If you want this functionality, I recommend not using it as-is, given the security vuln GitHub is currently reporting. Rather, anyone has my permission to copy the code verbatim into your project. It's a pretty simple gem.
Re:Strong_password Rubygem hijacked
by audience_mem on Monday July 08, 2019 @05:10PM
(#20386794)
Could you clarify?
Is the algorithm deficient?
To me that looks like code that indeed checks the strength, so I must be missing something.
Re:Strong_password Rubygem hijacked
by pharrington on Tuesday July 09, 2019 @02:36PM
(#20395163)
It checks the length of a password, along with an arbitrary scalar for repeated characters. It does not do any entropy calculations.
The writer of that code at least needs to read https://nvlpubs.nist.gov/nistpubs/legacy/sp/nistspecialpubli... one more time.
Does it, though?
https://github.com/bdmac/strong_password/blob/master/lib/str...