News for hackers. Stuff that matters.
Re:Show HN: YouTube-DL GUI Powered by Electron by josteink on Tuesday July 02, 2019 @04:14AM (#20333189)
Skimming the code I see main.js hasn’t got a single semicolon.

If you want to invite others to contribute, you may consider adopting a more widely employed js code-style.

This seems to be written in a very personal, opinionated and unconventional way.

Re:Show HN: YouTube-DL GUI Powered by Electron by lukey_q on Tuesday July 02, 2019 @04:58AM (#20333376)
Writing personal projects in a personal way seems just fine to me :) Looking at that file it's very obvious what's happening after just a cursory glance. I'd much prefer code that's very easy to understand without semicolons than the opposite.
Re:Show HN: YouTube-DL GUI Powered by Electron by mayeaux on Tuesday July 02, 2019 @12:48PM (#20336911)
Even though people have downvoted you, personally I agree with you, I haven't added any semicolons to main.js though because that file was automatically created in the original project I forked, if I ever have to edit it I will add the semicolons as I'm there but I haven't touched that file yet.
Re:Show HN: YouTube-DL GUI Powered by Electron by tom_ on Tuesday July 02, 2019 @09:30AM (#20334752)
That file is a copy of a stock one from the quickstart guide: https://github.com/electron/electron/blob/master/docs/tutori...
Re:Show HN: YouTube-DL GUI Powered by Electron by hombre_fatal on Tuesday July 02, 2019 @04:23AM (#20333225)
Might as well die on the hill of tabs vs spaces or single-quotes vs double-quotes or trailing commas or space after function name.

More useful advice would be: use Prettier and ship a .prettierrc so people can trivially transform their contributions into code consistent with the rest of the project.