News for hackers. Stuff that matters.
Re:Near-duplicate features of C++ (2017) by hermitdev on Thursday May 23, 2019 @08:01PM (#19997228)
I dont know offhand if it's illegal, but it's certainly unnecessarily verbose. Likewise, every compiler I've used accepts it, but it's unnecessary. Also, maybe a difference in behavior if code is in 'extern "C"' or not. I'm not sure. I rarely directly deal with C libs and havent been doing C++ for about 6 months now.
Re:Near-duplicate features of C++ (2017) by harry8 on Thursday May 23, 2019 @09:49PM (#19997794)
Unnecessary is a question of taste, right?

foo(void) seems less likely to cause confusion to anyone who hasn't got that C vs C++ distinction uppermost in their mind - I didn't. Nobody knows C++, we all know a subset of it and a smaller subset than we think we do and actually use, despite pretty constant study! Anything you do that makes a reader less likely to be confused, to make it less likely that they will or should break their flow by looking up the rule, is a good thing (tm).

C++ suffers from "macho coding" styles and ethos quite badly. "I /believe/ I understand this subtlety at this moment so anyone who doesn't is stupid." Even when we didn't understand it ourselves just last week we forget it(!) We fool ourselves into thinking anyone who hasn't got at least a decade of hacking C++ every day is unworthy of reading our code, possibly pretending that 6 months can attain that level of oneness with changing standards.

I try to use popular and safer features without thinking about it and if I want to use something slightly less popular when there is a choice, I ask "what problem am I solving? Is lowering readability a price I'm happy to pay here?" Before charging ahead with it. I probably classify some of the latter as the former due to over-familiarity.

The ideal C++ code is rapidly readable and understandable without extremely taxing effort by a smart highschool student with 2-3 months of C++ experience. (Note the use of the word ideal in that sentence). s/C++/any language/ is also applicable.

Other than following the style of the project you're working on is there any reason to use a reference ever over say a const pointer? Or a const pointer to a const object? The syntax then makes it clear you're not dealing with a pass-by-value copy. Maybe in another world everything would be const by default and have to be marked mutable then references might go away - but C++ couldn't do that and compile C which explains /some/ of the tension inside the language between various C++ features. Shame they didn't make references const by default if they had to introduce them. And member functions defaulting to const and explicit constructors by default. Const construction by default etc. There was an opportunity lost a long time ago to tighten up everything that isn't legal C as far as possible with the programmer having the option with an additional keyword.

Re:Near-duplicate features of C++ (2017) by zvrba on Friday May 24, 2019 @02:33AM (#19999028)
> Other than following the style of the project you're working on is there any reason to use a reference ever over say a const pointer?

One reason is to use overloaded operators. With pointers, adding two matrices which are arguments to a function would look like `( <star>a ) + ( <star>b )` (using asterisk makes the text italic); with references it's just `a+b`.

Another, stylistic, reason for which I use references is as a hint for two things: 1) the parameter is NOT optional (whenever you see a pointer parameter you wonder whether it can be null), and 2) that no ownership is transferred.

For these reasons, unless I actually need a pointer (e.g. optional parameter), I use references: less syntactic clutter at both call-site and use-site. With a decent IDE, it's easy to see how the parameter is passed.

> And member functions defaulting to const

That wouldn't fly and in many scenarios it wouldn't make sense because whether an operation is "const" is unclear. Like, you have a class representing a socket, and methods like read, write and close. None of the methods change the in-memory contents of the class (so, yes they're technically const), yet their behavior changes depending on the sequence in which they're called, e.g., calling close before write instead of the other way around (so no, they're not really const).

Re:Near-duplicate features of C++ (2017) by harry8 on Friday May 24, 2019 @03:06AM (#19999152)
const by default: I think I explained badly or you read too much into it or both. This is pure syntactic sugar I'm talking about. Instead of marking const member functions const, you mark functions which aren't const "mutable." Literally no change to the semantics of the language, just which one is assumed if you leave it blank. Right now it's mutable by default if you do nothing, it could just as easily have been const, you need to be able to tell the compiler which one you mean with a keyword whichever one is chosen to be represented by no token.

If "everything should be const unless it has to be mutable" is a reasonable position to take - which many seem to, then it should be the default, right? Too late for that now.

(<star>a) + (<star>b) yeah it's reasonable use. I can't say I care much. Obviously need references for the return value of an operator overload too if you're having operator overloading. It's reasonable. Doesn't thrill me, people have different taste on it which is reasonable too..

IMHO if the answer is "IDE" that's a workaround to a language issue and it may not be a big language issue either but it exists. C++ and Java both have some of that. Is the function taking the arg by mutable reference because Dave forgot? Or was did he have constication hell and a deadline so applied prune juice liberally? Or is it an output? Documentation in the header, popped up by your ide/text editor? sure, but that's also a workaround for something that would be nice if it were clear just by looking.

Re:Near-duplicate features of C++ (2017) by zvrba on Friday May 24, 2019 @12:34PM (#20003181)
> If "everything should be const unless it has to be mutable" is a reasonable position to take

For a language like C++ I don't think that's a reasonable position. "Good" class design is about a class encapsulating some behavior and providing methods to access that behavior. Any "interesting" behavior is based on mutable state, whereas const methods are useful only as observers of the state. So "const" as default would make the code more cluttered...

Heck, Java and C# don't even have const (though recent version of C# have added kind-of struct constness...)

> sure, but that's also a workaround for something that would be nice if it were clear just by looking.

In any sufficiently large program, nothing is clear just by looking. Such "local artifacts@ (like, explicit address-of operator) are irrelevant, the fewer the better. Writing `unique_lock<mutex> lk(&my_mutex)` would not add the tiniest bit of clarity compared to what you write now `unique_lock<mutex> lk(my_mutex)`

> Is the function taking the arg by mutable reference because Dave forgot?

That's easy to check: change it to const and see whether the method still compiles.

> Documentation in the header, popped up by your ide/text editor?

In the end, you always have to go to the function's definition and inspect it, and possibly follow the call chain further to find out what's really happening (i.e., the top-level call site is no longer relevant), and that's where IDEs shine. And no amount of syntax changes is going to save you from a const reference being aliased by a non-const one.

Re:Near-duplicate features of C++ (2017) by harry8 on Friday May 24, 2019 @02:29PM (#20004093)
We're just going to have to agree to disagree on that. Const by default would have saved me quite a few headaches over the years and C++ syntax is the definition of cluttered. Good C++ code has the majority of function parameters marked const. A non const reference member function parameter is usually a warning to look carefully, isn't it?

"Everything should be made const in your code unless it can't be" is advice metered out by the likes of John Carmack, Scott Myers etc. so it's pretty popular and oft repeated. The prevailing C++ zeitgeist perhaps. Could still be wrong, absolutely, don't stop thinking there by any means. Constification of a codebase can be a major pain in the butt.

Re:Near-duplicate features of C++ (2017) by kllrnohj on Friday May 24, 2019 @12:26PM (#20003121)
mutable already exists and means something different from non-const.

   class foo {
     void b1();
     void b2() const;
     void b3() mutable;
   }
b1, b2, and b3 are all distinct.
Re:Near-duplicate features of C++ (2017) by harry8 on Friday May 24, 2019 @02:09PM (#20003937)
Distinct indeed, they've got different names. If they're all called b1() then what? But you're hung up on "mutable" as a keyword. What is the semantics of b1(). The language could make them const semantics instead and so also provide a different keyword for 'non-const' maybe 'nonconst' would do if it really clashes with 'mutable' (I don't care if it is, I'm not proposing this to the committee as it's insane to be incompatible with existing code). When it was all just a twinkle in Bjarne's eye, he could have gone that way. Should have, say I.
Re:Near-duplicate features of C++ (2017) by earenndil on Saturday May 25, 2019 @01:30AM (#20007297)
That's no different to a class having a pointer to memory outside the class, which is modified by the const member function.
Re:Near-duplicate features of C++ (2017) by hermitdev on Thursday May 23, 2019 @10:39PM (#19998008)
I largely agree with what you say, but can you elaborate on what you mean by "macho coding" styles? I'm guessing youre referring to when one deigns venture into template metaprogramming. TMP is an area with 2 decades of experience, I can basically only do it with a copy of the standard and/or relevant reference material handy. Although I'd consider my C++ knowledge in the 95th percentile or so, I probably know less than 20% of the std lib well. I've read most of the +1200 pages of the C++11 spec, but ive not kept up to date since, sadly, because its no longer my daily language.
Re:Near-duplicate features of C++ (2017) by harry8 on Thursday May 23, 2019 @11:42PM (#19998276)
What I mean is anything that is showing off, has a lack of humility and implicitly disparages others in a way that is totally unneeded while producing lower-quality, less-maintainable, less robust code. Being clever for the sake of appearing clever. That kind of thing.

    if(condition)
        I_am_tough_so_I_do_not_brace();
The un-braced block is a classic "macho" pose in code. leaving out a '{' and a '}', two characters, has no benefit in any way, shape or form. It is decrying "I will never make a mistake with this loose razor blade if you do maintaining it is because you suck" There is literally no reason to do it ever, under any circumstances. Yet I have, and we do. We can change. Now watch the arguments presented when you bring un-braced blocks up. They're insanely ridiculous. (vertical space, need static analysis, etc.) If you were betting your retirement savings on no bug in the line of code now or in the future, you'd be very nervous about it sure. And then you would brace it. Unbraced blocks are a minor thing that mostly don't matter. I wouldn't fight too hard over it. It's just that it's so very, very clear that one way is bugs for zero benefit while the other isn't. Meh.

So here's Bjarne being "Uber-Macho" to the delight of the conference crowd. Note the quote:

"I think I understand what you're saying and I think you happen to be wrong." (crowd whoops in glee). https://youtu.be/OB-bdWKwXsU?t=4141

This is a pretty ugly way of saying "I disagree and this is why..." But the crowd loves it. That attitude gets into our code. "Macho coding" is the best descriptive name I can manage. Maybe there's a better one? (Note I agree with the content of Bjarne says, I just think he's being an asshole about it, why do that? https://www.urbandictionary.com/define.php?term=Waltersobcha... )

Re:Near-duplicate features of C++ (2017) by kllrnohj on Friday May 24, 2019 @12:25PM (#20003102)
> Other than following the style of the project you're working on is there any reason to use a reference ever over say a const pointer?

Yes, definitely. It codifies nullability. const pointers should _typically_ be const references instead, see https://google.github.io/styleguide/cppguide.html#Reference_...

> Maybe in another world everything would be const by default and have to be marked mutable then references might go away

I'd definitely +1 a references are const by default, but that would not make references go away at all. You'd still have references (non-null) and pointers (null) just for the reason of non-null vs. null. This is a very useful distinction. So much so Kotlin built an entire language around it.

> The syntax then makes it clear you're not dealing with a pass-by-value copy.

Which is not a useful behavior difference. If it's const why do you care if it's pass-by-value or pass-by-reference? It doesn't change behavior and it doesn't even tell you anything about the performance of the call (there are plenty of pass-by-pointer calls that are slow and plenty of pass-by-value that are not - it depends on the size of the argument, and what the function is doing)

Re:Near-duplicate features of C++ (2017) by harry8 on Friday May 24, 2019 @02:17PM (#20004000)
when you read a function call

    foo(bar, baz, bajinga);
Which of those are pass by value, by reference or by const reference? I say it would be useful to know that by inspection from just reading that line of code. You don't have to agree. And you care about by value vs by reference because copy constructors exist and you need to reason about performance or if you don't need to why are you using c++ anyway?

You mostly care whether it's by value or by reference because what is passed could be altered with the latter unless it's marked const. But which is it? Stop! Stop what you're reading right now and go and look at the foo() signature. 9 times in 10 you won't be surprised, the arguments should not be altered by the function call but you might want to check that, then get back to whatever you were actually trying to understand with a break in the flow of your understanding and the prospect of some context fading slightly from your short term memory.

But yeah some people are so smart that there is literally nothing in coding readability they need and sneer at those of us who take a different approach. Such people never make mistakes. Twas ever thus, well before C++.

Re:Near-duplicate features of C++ (2017) by kllrnohj on Tuesday May 28, 2019 @02:15PM (#20032791)
> And you care about by value vs by reference because copy constructors exist and you need to reason about performance or if you don't need to why are you using c++ anyway?

That's an implementation detail of the function you're calling, not a performance issue at the call site. The call site should not have an opinion on this. Either the object is big enough it should be pass-by-reference, or it's not. You don't need to sprinkle that detail at every call site.

> You mostly care whether it's by value or by reference because what is passed could be altered with the latter unless it's marked const.

For mutable parameters I agree, those should be passed by pointer. Because they actually have an influence at the call site.

But const references, which is what we were talking about, have no behavior change at the call site. So they should not stand out or be marked special, since they aren't.

> But yeah some people are so smart that there is literally nothing in coding readability they need and sneer at those of us who take a different approach.

If you insist all pass-by-const-refs should be pass-by-pointer then you've also lost your ability to code-style distinguish mutable vs. non-mutable parameters. Which makes it much easier to make mistakes, not harder. And also litters your code base with meaningless, non-behavior-altering noise.

Re:Near-duplicate features of C++ (2017) by nayuki on Saturday May 25, 2019 @07:29AM (#20008387)
Rust is a relatively new programming language that features nearly all the good parts of C++ (e.g. struct, reference, RAII, move semantics, generics) and almost none of the bad parts (e.g. duplicate features, cryptic syntax, undefined behavior).

Your example in Rust would read like this:

    // Definition
    fn foo(a: u8,  b: &u8,  c: &mut u8) -> i32 {
        a = 0;  // Local change only
        println!("{}", *b);  // Read pointee
        *c = 1;  // Write pointee
        return 2;
    }
    
    // Call site
    let bar: u8 = 3;
    let baz: u8 = 4;
    let mut bajinga: u8 = 5;
    foo(bar,  &baz,  &mut bajinga);
Re:Near-duplicate features of C++ (2017) by steveklabnik on Saturday May 25, 2019 @11:23AM (#20009520)
You shouldn’t need the type annotations on the three variables, by the way.