Re:Some AMD CPU's RDRAND might not return random data after ...
by zaroth on Wednesday May 08, 2019 @03:51PM
(#19862249)
The Bugzilla report seemed to indicate that AMD was returning an error code, because OpenSSL was failing to generate a key, not generating a bad key?
Why would OpenSSL fail visibly if the API was returning success but with non-random data?
Re:Some AMD CPU's RDRAND might not return random data after ...
by int_19h on Wednesday May 08, 2019 @11:31PM
(#19865129)
If you look closely at one of the error messages, it says "too many iterations", in what looks like a random generator. I wonder if at some point it has to iterate to get a number different from another one, and it just gets an endless stream of identical values?
Re:Some AMD CPU's RDRAND might not return random data after ...
by zaroth on Wednesday May 08, 2019 @11:51PM
(#19865212)
I can’t imagine the code is checking the returned value for uniqueness after seeing a SUCCESS code, and iterating in the hopes that becomes less true.
That would be quite something to read the comment on;
// Here we check to be sure the Earth is not flat
...
// Seeing that the Earth is indeed flat, we will iterate in this absurdity some more in the hopes it rounds out eventually
* https://github.com/systemd/systemd/issues/11810#issuecomment...
There is no "however". This bug is about code that is, according to the AMD doco, using the instruction correctly; but that is, because the AMD processor has this possible state after a suspend+resume, getting all-ones as its random data, thereby causing ID collisions in a fairly wide range of possible things from freshly re-generated machine IDs to journal file header block IDs, and including unit invocation IDs.
* https://github.com/systemd/systemd/blob/717e8eda77b93ac396dc...
* https://github.com/systemd/systemd/blob/717e8eda77b93ac396dc...
* https://github.com/systemd/systemd/blob/717e8eda77b93ac396dc...
This indicates that a "should be fine" in another comment is not in fact true. (-:
* https://github.com/systemd/systemd/blob/717e8eda77b93ac396dc...