News for hackers. Stuff that matters.

A comment on Commit messages guide. Parent comment

Re:Commit messages guide by andreareina on Saturday April 20, 2019 @12:48AM (#19704858)
Imperative vs past is a stylistic issue and in the end doesn't impact how the commit message is understood.

My understanding is that pull request is a GitHub-ism. What git itself has is `git format-patch`, which does exactly what it says on the tin.

[ Parent | on HN ]
Re:Commit messages guide by u801e on Saturday April 20, 2019 @11:40AM (#19707095)
> My understanding is that pull request is a GitHub-ism.

It is, but git has a command called request-pull[1]. Linus Torvalds has said[2] that certain aspects of the Github pull request process are not suitable or make it very difficult to submit patchsets for review for the linux kernel and that they should have followed the implemention used in git-request-pull instead.

[1] https://git-scm.com/docs/git-request-pull

[2] https://github.com/torvalds/linux/pull/17#issuecomment-56546...

[ Parent | on HN ]
Re:Commit messages guide by andreareina on Monday April 22, 2019 @02:06AM (#19716885)
Didn't know about request-pull, thanks!
[ Parent | on HN ]