News for hackers. Stuff that matters.
Re:How the Boeing 737 Max disaster looks to a software Devel... by adreamingsoul on Thursday April 18, 2019 @06:00PM (#19695174)
Recently, I had someone join my team who was instantly popular and everyone enjoyed this person's personality. I trusted this person more then I should have and during a period when I was unable to give enough attention to their code reviews, they introduced several critical bugs and defects into the production environment.

I never figured out if it was ignorance or laziness. But, either way I learned a valuable lesson. It was also a reminder to me that not everyone has the same level of ownership or commitment that I would expect.

Re:How the Boeing 737 Max disaster looks to a software Devel... by crescentfresh on Thursday April 18, 2019 @06:06PM (#19695230)
> not everyone has the same level of ownership or commitment that I would expect

This is a good way of putting it. A dev might be junior and won't have the knowledge or skill to build stuff with minimal defects, but they can still have the sense of ownership and commitment to a quality product that a senior/trusted dev on the team has.

Re:How the Boeing 737 Max disaster looks to a software Devel... by underwater on Thursday April 18, 2019 @08:10PM (#19695923)
If the only gatekeeper against shipping bugs is a senior engineer catching bugs in review, then that's possibly a sign that your processes need improvement, rather than the people.
Re:How the Boeing 737 Max disaster looks to a software Devel... by tremon on Friday April 19, 2019 @05:24AM (#19698110)
Not rather; in addition to would be more appropriate.
Re:How the Boeing 737 Max disaster looks to a software Devel... by quickthrower2 on Thursday April 18, 2019 @07:53PM (#19695823)
They are new to the team and are not getting sufficient code reviews. I wouldn’t put the blame on them. There is a lot of gotchas in an unfamiliar codebase. Although they probably should have known this and insisted on a full review if they are at senior level.
Re:How the Boeing 737 Max disaster looks to a software Devel... by megaremote on Thursday April 18, 2019 @10:48PM (#19696701)
Maybe, but code reviews don't catch everything. They never can. Relying on them can also be a mistake.
Re:How the Boeing 737 Max disaster looks to a software Devel... by toomuchtodo on Thursday April 18, 2019 @10:56PM (#19696737)
If you can't trust code reviews for reviewing code of someone relatively new to a codebase, what can you trust (besides tests)? Despite tests and reviews, you might still introduce bugs into production code.