News for hackers. Stuff that matters.
Re:Errors – Gotta Catch 'Em All by wvenable on Thursday April 04, 2019 @12:24PM (#19574151)
Java has checked exceptions (which honestly is more like error-return) and the innerException property is used extensively to hold the "real" exception and, of course, it's type is just "Exception".

Making the real error types part of the signature of the method means that implementation changes require changing the signature, completely breaking encapsulation. In fact, I'd argue it makes polymorphism completely impossible.

Re:Errors – Gotta Catch 'Em All by kaoD on Thursday April 04, 2019 @12:39PM (#19574305)
> Java has checked exceptions (which honestly is more like error-return) and the innerException property is used extensively to hold the "real" exception and, of course, it's type is just "Exception".

Yeah, well, Java's semantics and programer laziness make a mess. News at 11.

> I'd argue it makes polymorphism completely impossible.

Oh, so two birds with one stone!

Re:Errors – Gotta Catch 'Em All by wvenable on Thursday April 04, 2019 @12:45PM (#19574393)
It's like it's 1992 all over again. Every change requires changing every caller everywhere. Yes, it's an improvement now that the typechecker will tell us all the places we need to change but it still doesn't sound enjoyable or useful.
Re:Errors – Gotta Catch 'Em All by kaoD on Thursday April 04, 2019 @01:34PM (#19574960)
> Every change requires changing every caller everywhere

I don't see why.

Re:Errors – Gotta Catch 'Em All by wvenable on Thursday April 04, 2019 @01:38PM (#19575005)
Non-trivial changes to functions typically change what errors they will trigger. Thus changing what errors their callers will trigger. And so on.

Putting error conditions in the function signature means that the signature reflects the implementation details of the function. Change those implementation details and the signature changes, affecting the callers and their signatures. Unless you abstract the error and then you lose the only advantage of passing the errors around rather than using exceptions.

Re:Errors – Gotta Catch 'Em All by kaoD on Thursday April 04, 2019 @01:49PM (#19575114)
I still don't see why.

https://play.rust-lang.org/?version=stable&mode=debug&editio...

Let's add a new error condition:

https://play.rust-lang.org/?version=stable&mode=debug&editio...

Only the function raising the error, and the consumer, had to change (and the consumer only changed because it _cared_ about the error type!)

If you want an example with nested errors I can do it, you'll see it's mostly the same.

Re:Errors – Gotta Catch 'Em All by wvenable on Thursday April 04, 2019 @01:55PM (#19575190)
If you had an external compiled library the consumed MyError or called caller, you just broke it, becuase you changed the type.

This isn't a realistic example at all because your MyError is simple enum that you changed to make it work. If you add another error, or have more than one level, or call it multiple locations, and don't eat the error then now you're changing many more functions, just as I said.

Re:Errors – Gotta Catch 'Em All by kaoD on Thursday April 04, 2019 @02:01PM (#19575254)
> This isn't a realistic example at all because your MyError is simple enum that you changed to make it work.

Well, that's what an error is. A simple enum of the error cases and maybe some metadata.

EDIT: e.g. IO errors in Rust's std: https://doc.rust-lang.org/src/std/io/error.rs.html#91-174

If your first guess is this isn't realistic because it's "too simple" then maybe you've never been exposed to this kind of error handling? It's so simple it's unbelievable?

> If you add another error

That's what I did, I added a new error.

> or have more than one level and don't eat the error now you're changing more methods, just as I said.

As I said, if you want an example with nested error types I can do it:

https://play.rust-lang.org/?version=stable&mode=debug&editio...

As you can see, caller() (which would be our "middleman" here, the one that neither produces nor uses the error) didn't change at all.

> If you had an external compiled library the consumed MyError or called caller, you just broke it, becuase you changed the type.

You mean a dynamically-linked library? Yep, completely broken, but that's not the only problem with DLLs. Static linking is fine.

Anyways, the contract changed, so it's a breaking change, so that's good in my book. The contract changed in the case of exceptions too, you just hand-waved over the issue and called it a day.

Wouldn't it be the same with exceptions across library boundaries?

Re:Errors – Gotta Catch 'Em All by wvenable on Thursday April 04, 2019 @02:47PM (#19575755)
> If your first guess is this isn't realistic because it's "too simple" then maybe you've never been exposed to this kind of error handling?

I explained why the example is too simple. If you coded this in C with an integer error code the code would also be roughly the same size.

> Wouldn't it be the same with exceptions across library boundaries?

Actually no. That's the significant difference.

I can freely change the implementation and if that causes new and different exceptions to be possible, that doesn't affect the implementors. And most of the time such a change makes will make material affect on the implementors so they are broken for nothing.

Re:Errors – Gotta Catch 'Em All by kaoD on Thursday April 04, 2019 @03:13PM (#19576032)
> I explained why the example is too simple.

And I offered a second example with a nested error, and nothing changed. Errors are just enums, there's nothing more complex than this. It's that simple.

> If you coded this in C with an integer error code the code would also be roughly the same size.

But it wouldn't check the error types. It's a zero-cost abstraction.

> I can freely change the implementation and if that causes new and different exceptions to be possible, that doesn't affect the implementors.

Neither does in my case... unless I care about the actual errors, which I did in this case in main() just for completeness.

Re:Errors – Gotta Catch 'Em All by wvenable on Thursday April 04, 2019 @03:57PM (#19576470)
Honestly, that second example is more complex. Now you're had to manually map one error onto another in order to propagate it. How big does MyError get when you have OtherError, AnotherError, FailureNum5, ChokedOnBanana. You're just doing busy work creating types and mapping them together. And this is just a simple toy example! You're quick to hand-wave that wasted effort.

What value is the enum value Other(OtherError) actually provide other than to satisfy the compiler? How far do we take this when there are more levels? OtherFailure(OtherMistake(Other(OtherError)))?

> Neither does in my case...

In each example you changed the implementation of type so that it is no longer compatible. You altered the signature of the method.

> But it wouldn't check the error types. It's a zero-cost abstraction.

It's funny that you say that as error returns have a non-zero runtime cost. Yet exceptions can actually be zero-cost at runtime (if they aren't thrown) as they can be implemented out of band. Only the most naive implementation propagates exceptions with multi-value returns.

Now I do understand why Rust is implemented this way but it's not because error returns are unequivocally better.

Good code with exceptions have very little code actually related to error handling. Throw often, catch infrequently, and use normal resource cleanup for exceptional cleanup as well. You can get far with a 2-3 well placed catch statements and that's it. No extra typing. No error propagation code.

If you think of error handling as happening where the error is raised as opposed to where it is handled it's hard to see the advantage of exceptions. Where the error is raised is not that important.

Re:Errors – Gotta Catch 'Em All by kaoD on Thursday April 04, 2019 @04:55PM (#19577006)
I see your point and I will consider it. Thanks for the discussion.

What's a language that does exceptions just right for you?

Re:Errors – Gotta Catch 'Em All by wvenable on Thursday April 04, 2019 @05:06PM (#19577110)
C#/C++ do exceptions fine. However, it's more useful to point out the language that does exceptions all wrong: Java. I feel like the current anti-exception sentiment is mostly due to programmers first or major experience with exceptions is checked exceptions in Java.

If I had to choose between checked exceptions and well typed error propagation, I'd choose the latter hands down. Checked exceptions have all the disadvantages of error returns and none of the advantages.

This meshes with my point about where the error concerns are; Java requires you to be very concerned about what errors are thrown at every method definition and call. But C#, which is a very similar language, doesn't. In C#, you only have to be concerned about where and what errors you can handle.