News for hackers. Stuff that matters.
Re:CVE-2019-5418 – File Content Disclosure on Rails by MaxGabriel on Thursday March 21, 2019 @07:09PM (#19458278)
Does the code fixing this feel a little too innocuous to other people? Reading the code it seems really unlikely I'd see this and realize that deleting it would create a severe security vulnerability:

    v = v.select do |format|
      format.symbol || format.ref == "*/*"
    end
https://github.com/rails/rails/blob/efb706daad0e2e1039c6abb4...
Re:CVE-2019-5418 – File Content Disclosure on Rails by tenderlove on Thursday March 21, 2019 @07:39PM (#19458418)
Ya, that's one reason I rewrite the commit message to add the CVE. Hopefully people will view the blame before changing.
Re:CVE-2019-5418 – File Content Disclosure on Rails by decasia on Thursday March 21, 2019 @07:56PM (#19458507)
I'm curious — is it not normal to add in-line explanatory comments in the Rails codebase?

I'm thinking if I were writing this code in an application, and it looked this cryptic, I might at least add a comment noting what it was for. Not that people shouldn't look in git. But inline is easier to notice, no?

Re:CVE-2019-5418 – File Content Disclosure on Rails by riffraff on Friday March 22, 2019 @01:50AM (#19459926)
Don't we have tests for this?
Re:CVE-2019-5418 – File Content Disclosure on Rails by progval on Friday March 22, 2019 @04:19AM (#19460452)
Re:CVE-2019-5418 – File Content Disclosure on Rails by tptacek on Thursday March 21, 2019 @07:21PM (#19458330)
Why would you randomly remove code from ActionView? It's some of the least user-serviceable code in Rails.
Re:CVE-2019-5418 – File Content Disclosure on Rails by tenderlove on Thursday March 21, 2019 @07:41PM (#19458428)
We're working to improve it. It's actually why jhawthorn found this issue.