News for hackers. Stuff that matters.
Re:The Sad State of Logging Bugs for Apple by valleyer on Sunday March 10, 2019 @04:04AM (#19350927)
> I would poke around at code and attempt to make theoretical fixes for bugs I couldn’t reproduce.

This sounds like a great way to accrete unnecessary code, some of which will create even more bugs.

Re:The Sad State of Logging Bugs for Apple by redwoodmonkey on Monday March 11, 2019 @10:47AM (#19359351)
Code to fix problems, even in theory, isn't unnecessary. Statistically, changes I did were very unlikely to produce bugs. I wrote about this in my post about why you shouldn't do code reviews: https://www.corbinstreehouse.com/blog/2018/01/code-reviews-p...
Re:The Sad State of Logging Bugs for Apple by valleyer on Tuesday March 12, 2019 @03:05AM (#19365984)
Interesting article!

I worked for 5 years on a team who had just started using code reviews. What we found was that code reviews didn't often find bugs in the changes themselves, but they were very effective at preventing bad decisions that would cause bugs in the future.

There are lots of ways to make a change that gets the job done, and might even fix a bug, but can mean twice as much work to deal with in the future. These range from intentional but shortsighted hacks to simple mistakes by experienced engineers working in a large project.

You also mention style nits. I admit even I get annoyed by these. But bad style can make it harder for new hires to learn the codebase, which slows the team down. In rare cases, they can even result in bugs of their own like the infamous Apple "goto fail" bug.

Every team is different, but I can't imagine working on one without code reviews now.

Re:The Sad State of Logging Bugs for Apple by wereHamster on Sunday March 10, 2019 @07:55AM (#19351587)
I doubt he actually committed the changes to their 'master' branch. I keep a lot of such tiny experimental changes in my local branches.
Re:The Sad State of Logging Bugs for Apple by redwoodmonkey on Monday March 11, 2019 @10:45AM (#19359337)
FWIW, I would check in these fixes. Sometimes they would work, sometimes they won't.