Effective Code Reviews – A Primer

Re:Effective Code Reviews – A Primer by detaro on Thursday March 07, 2019 @12:15PM (#19329847)

> Because it signals to me that the only one who understands this piece of business logic that we have applied to our code base is a test, which is a piece of code.

That's a weird leap of logic. No, it does not mean that. It means that a human wo understood that piece of logic wrote a test, so the test can in the future warn about issues before a human spends time on checking if it still works like it should.

[ Parent | on HN ]

Re:Effective Code Reviews – A Primer by misterman0 on Thursday March 07, 2019 @12:25PM (#19329942)

I disagree with the notion that this leap is weird.

>> No, it does not mean that. It means that a human wo understood that piece of logic wrote a test

I don't not trust a human to understand (1) a piece of logic nor to understand (2) a test written by someone who does not understand said piece of logic.

[ Parent | on HN ]

Re:Effective Code Reviews – A Primer by detaro on Thursday March 07, 2019 @12:26PM (#19329961)

So how are you implementing code when you don't understand the logic of what it does? How do you make sure it does what it is supposed to do?

[ Parent | on HN ]