Re:Shopify's path to Rails 3
by speleding on Tuesday November 16, 2010 @06:09PM
(#1912128)
I'm almost done with upgrading myself and the XSS stuff does take a lot of effort. I am very surprised the Shopify blog says they checked for XSS error manually though because it's very easy to add something to your test helper that checks every @response.body for sequences like "<" and runs the result through HTML tidy. That catches 95%.
By the way, a patch of mine is in rails 3.0.3 that just came out and now you can just do a global replace of <%= with <%== and be mostly done with it. But that would be cheating.
The tidy lib is installed by default on the Mac. It's very fast (written in C) so it only adds a few seconds to my tests. (I'm leaving it in after the conversion.)
Another tip: it helps to put a lot of <&bad"> tags in your fixtures, that will trigger a bunch of errors in the above test if you are not doing your escaping properly.
Re:Shopify's path to Rails 3
by ludicast on Tuesday November 16, 2010 @02:39PM
(#1911295)
Keep pluging away, it's way worth it :).
Rather than use the upgrade gem I started a new project, copied/converted what I could, and then let my tests tell me what was missing. First the models, then controllers, and finally the integration tests.
Without automated testing you're fucked of course, but as long as you have a decent safety net in place you'll get there.
Re:Shopify's path to Rails 3
by ludicast on Tuesday November 16, 2010 @02:34PM
(#1911278)
The article brings up a great point wrt XSS. I'd say the new XSS stuff was responsible for 2/3 of the upgrade-errors my automated testing didn't catch, so pre-fixing this like they did would have had big rewards. But I was too impatient so after the upgrade I let my client feedback cover the edgecases :).
I'd actually say upgrading to Ruby 1.9.2 gave me more headaches than upgrading Rails.
Re:Shopify's path to Rails 3
by xal on Tuesday November 16, 2010 @02:39PM
(#1911298)
Cool that you managed to upgrade to 1.9.2. The encoding issues have us scared. We do have a few special purpose webapps that run 1.9.2 because of very high performance requirements.
Re:Shopify's path to Rails 3
by ludicast on Tuesday November 16, 2010 @03:01PM
(#1911388)
The encoding issues bit me in a few places (especially with paperclip), and I have some hacky initializers running that monkeypatch a few libraries to behave well enough.
Re:Shopify's path to Rails 3
by cpg on Tuesday November 16, 2010 @10:31PM
(#1912768)
> Boot up Shopify in my development environment and click around
Hmm! With a staff of 11 FTE developers ... you would think they would put more weight on this aspect of the transition. But yeah, other priorities take over.
By the way, a patch of mine is in rails 3.0.3 that just came out and now you can just do a global replace of <%= with <%== and be mostly done with it. But that would be cheating.
The tidy lib is installed by default on the Mac. It's very fast (written in C) so it only adds a few seconds to my tests. (I'm leaving it in after the conversion.)
Another tip: it helps to put a lot of <&bad"> tags in your fixtures, that will trigger a bunch of errors in the above test if you are not doing your escaping properly.
I think it's best to think of Rails 3 as a separate project that happens to share some code with Rails 2.
I hope it's worth it in the end...
Rather than use the upgrade gem I started a new project, copied/converted what I could, and then let my tests tell me what was missing. First the models, then controllers, and finally the integration tests.
Without automated testing you're fucked of course, but as long as you have a decent safety net in place you'll get there.
I'd actually say upgrading to Ruby 1.9.2 gave me more headaches than upgrading Rails.
Encoding issues rank up there with Array.to_s pains when moving to 1.9
Hmm! With a staff of 11 FTE developers ... you would think they would put more weight on this aspect of the transition. But yeah, other priorities take over.