News for hackers. Stuff that matters.

A comment on CodeFlow: Improving the Code Review Process at Microsoft (2018). Parent comment

Re:CodeFlow: Improving the Code Review Process at Microsoft ... by someoneelse67 on Thursday February 07, 2019 @10:06AM (#19105608)
But you actually can setup rules to prevent merges unless certain people/groups have approved. It sounds like you and your team are suffering more from bad code review habits than a bad tool. Devs should review what they are publishing to their peers at least once before actually hitting the publish button. It’s a courtesy to them and their time

I personally love the Crux tool and some of its add ons.

[ Parent | on HN ]
Re:CodeFlow: Improving the Code Review Process at Microsoft ... by guitarbill on Thursday February 07, 2019 @09:18PM (#19110883)
> But you actually can setup rules to prevent merges unless certain people/groups have approved.

As detailed, that only prevents merging via the UX, not pushes to the main branch. Maybe the team does suck, but I still consider it a shortcoming of CRUX et al.

[ Parent | on HN ]