CodeFlow: Improving the Code Review Process at Microsoft (2018)

Re:CodeFlow: Improving the Code Review Process at Microsoft ... by osel on Thursday February 07, 2019 @02:58AM (#19103757)

From my brief play with your demo it's a bit of both.

The toolkit is very small and lacks good definition of elements (both visually in that it lacks contrast, and practically in that I have no idea what is clickable or editable).

The page structure isn't that clear either, where are the column headings? And on my widescreen browser window the isn't a limit on horizontal stretch - I have to play with the browser to find a good width. Also, I can expand code, but how do I shrink/hide it?

[ Parent | on HN ]

Re:CodeFlow: Improving the Code Review Process at Microsoft ... by piotrkaminski on Thursday February 07, 2019 @03:03PM (#19108039)

Thanks! Sounds like switching toolkits should address many of these issues.

And no, you can't shrink/hide code, other than by re-diffing. What can I say -- it's surprisingly hard to implement and didn't seem worth it.

[ Parent | on HN ]