Re:Security Alert: Ethereum Constantinople Postponement
by DennisP on Wednesday January 16, 2019 @06:37AM
(#18919961)
A similar method is to put the external call at the very end of your function, after any state updates, and make sure that function isn't called from another function. These are well-known techniques in the community and commonly used, which is probably one reason the researchers didn't find any vulnerabilities in deployed contracts.
The gas limit on send was more of a belt-and-suspenders thing, not intended as the sole protection; that may have been a bad idea in retrospect, but at the time people were pretty focused on adding every protection possible against another DAO situation.
----------
bool isEntered = false;
function doSomething() { if (isEntered) { throw; } isEntered = true; ...; isEntered = false; }
----------
I don't really understand why they went with this gas-limit solution. I feel like there must be something I'm missing cause its too obvious.