News for hackers. Stuff that matters.
Re:Avo: Better X86 Assembly Generation from Go by pcwalton on Thursday January 10, 2019 @02:27PM (#18877145)
I really wish Go (really, Plan 9) hadn't made their own assembly syntax. The fact that we have AT&T syntax to deal with instead of just using Intel's syntax is bad enough.

I understand the rationale—that you can use the assembly syntax as a sort of IR by unifying the syntax of certain basic operations across different ISAs—but that's properly considered a low-level IR, not assembly. (It's also a pretty bad form of IR for doing any interesting optimizations, which is why Go uses a separate SSA form for that.)

Re:Avo: Better X86 Assembly Generation from Go by mmcloughlin on Thursday January 10, 2019 @02:52PM (#18877407)
Author of avo here. While I did really enjoy working on this project, I still fully agree with you.

Go (Plan 9) syntax is not sufficiently different to make it a powerful intermediate representation, hence SSA as you point out. In fact many of the differences are frustrating subtle changes in instruction mnemonics or operand order. This might be okay if there was a canonical instruction database that made all these differences from Intel and AT&T easy to discover. However these exceptions are really recorded in various parts of the golang.org/x/arch/x86 repo. Producing the instruction database for avo was quite a time-consuming process. See:

https://github.com/mmcloughlin/avo/blob/master/internal/load... https://github.com/mmcloughlin/avo/issues/23

I've gained a lot more familiarity with the assembler and supporting infrastructure, so I'm hoping I may be able to contribute to this area of the core Go project.

Re:Avo: Better X86 Assembly Generation from Go by pcwalton on Thursday January 10, 2019 @04:02PM (#18878122)
Yeah, AT&T syntax has much of the same issues of poor documentation. In particular, operand order is easy to remember for 2-operand instructions: it's reversed in AT&T. But now with SSE and AVX we have 3- or 4-operand instructions, and the AT&T versions sometimes put the operands in (2, 1, 3), sometimes in (3, 2, 1), etc. There's no documentation for this aside from GCC as far as I can tell. :(
Re:Avo: Better X86 Assembly Generation from Go by mmcloughlin on Thursday January 10, 2019 @04:19PM (#18878302)
Yes! This tripped me up at one point. My comment says "Otherwise we could be in the bizarre special-case of 3-argument CMP instructions."

https://github.com/mmcloughlin/avo/blob/0e253b3753beb409b3dd...

It gets to the point where the only source of truth is the Go assembler itself. My test suite takes the avo instruction database and generates a massive assembly file with one line per instruction form, then passes this to `go tool asm`.

Re:Avo: Better X86 Assembly Generation from Go by haberman on Thursday January 10, 2019 @06:05PM (#18879335)
Even just mapping between the mnemonics is non-trivial. You want to think that it's just a matter of removing size suffixes from AT&T, but it's sadly not that simple. "movslq" in AT&T maps not to "movsl" or even "movs" in Intel, but "movsxd". How is anybody supposed to figure that out?
Re:Avo: Better X86 Assembly Generation from Go by nickcw on Thursday January 10, 2019 @04:11PM (#18878217)
I've done a reasonable amount of ARM, x86 and amd64 programming with the go assembler.

It's quirks are annoying to start with, but if you use more than one assembly language you begin to see the advantages of a more consistent syntax between them.

I suspect the advantages for the go maintainers of a uniformish assembler syntax are the real reason for it.

Re:Avo: Better X86 Assembly Generation from Go by pcwalton on Thursday January 10, 2019 @08:06PM (#18880145)
I use ARM and x86-64 extensively and any minor inconvenience caused by different syntax for trivial operations is completely outweighed by the downside of being incompatible with the CPU vendor's manual.

LLVM MachineInstr and Cranelift do this much better than Go does, by maintaining a clean separation between the low-level IR and the assembly language.