As a former options trader, this is Taleb in a nutshell. He builds and attacks straw men for popular consumption. (The one time he tried running a hedge fund, it failed ruinously.)
Source? Taleb AFAIK does not publish his track record in a verifiable manner, so we're left to wondering if his bragging about himself really matches his record.
What I can say somewhat definitively is that any such research would be fairly outdated. IQ tests simply are not used at any scale that would be required to study such a correlation, and so if there are recent studies they'd likely rely on sparse data from a small subset of (possibly self-selected & biased) students.
SAT or other standardized scores are a different matter. But as my other comments in this thread state, those tests are very much not designed and calibrated to measure anything beyond 1st year college success. 1st year success does itself correlate with 2nd year, grad rates, etc., but the signal degrades significantly as time goes on.
I'm familiar with the school systems and their on boarding processes for new students in many parts of the country, and am not aware of any pockets that systematically utilize IQ tests.
You're correct about military recruits, but I don't know if their scores are reflective of the general population. Certainly the composition by demographics differ somewhat from the general population, which woild cause me some concern if I were trying to generalize from their IQ tests to the broader population.
However, the context of my comment was about IQ related to elite colleges, and that remains an area where the data is sparse for IQ scores of such students. There simply isn't much if any research being performed these days tying IQ to success in higher education.
They make no other primary research claims about the utility of how the test results should be used, and in dealing with them they are very up front about the importance of a good all around picture of a student including HS GPA, rigor of courses taken, etc., along with SAT as one of multiple metrics.
I repeat, it is pop culture that has distorted these tests beyond all reasonable correspondence to their actual intent.
But the reality is that IQ tests are only very, very rarely used. In fact a career on the periphery of academia, academic testing, and their efficacy in predicting academic success at the University level, I have never, not once, not from any colleague or at any conference encountered mention of an IQ test as something to be considered for practical use. I have a lesser degree of familiarity with grade school/high school testing methods, but (in the US) I am similarly unaware of any common practice here.