How to speed up the code review

Posted by seregazhuk on Saturday December 29, 2018 @02:22PM
from the sergeyzhuk.me dept.

https://sergeyzhuk.me/2018/12/29/code_review/

( 3 comments | 16 points | on HN )

Re:How to speed up the code review by jzoch on Saturday December 29, 2018 @08:09PM (#18786717)

I like the idea of the article but wish it showed HOW. Given 100 commits where each one is randomly one of the categories discussed what git Fu should I use to split it into 3 pull requests that cleanly adhere to the articles points?

[ Parent | on HN ]

Re:How to speed up the code review by mr_donk on Sunday December 30, 2018 @01:22AM (#18787778)

Start with `git rebase -i` to clean it up (reorder/squash), then create new branches and `git cherry-pick` the related commits into 3 branches. Submit PR/MR for those...

At least, that’s what I’d do. Curious to hear other ideas.

[ Parent | on HN ]

Re:How to speed up the code review by seregazhuk on Sunday December 30, 2018 @10:35AM (#18789613)

Exactly, interactive rebase and cherry-picking do the job.

[ Parent | on HN ]