Re:The Ant Design Christmas Egg That Went Wrong
by mp3k on Tuesday December 25, 2018 @06:53PM
(#18759685)
The code was there for months, there was just time trigger for 25th of Dec.
I'm loving ant, but this was stupid. At least it's free advertising so the project's user base can grow.
Re:The Ant Design Christmas Egg That Went Wrong
by crooked-v on Tuesday December 25, 2018 @06:14PM
(#18759569)
It sounds from the description like this "feature" was added in an earlier version, not something literally released on Christmas.
Re:The Ant Design Christmas Egg That Went Wrong
by c22 on Tuesday December 25, 2018 @06:56PM
(#18759704)
The point still stands. If open source code is vital to your business you should probably at the very least audit it.
Re:The Ant Design Christmas Egg That Went Wrong
by mp3k on Tuesday December 25, 2018 @07:10PM
(#18759747)
Good advice. Funny thing is, from May I'm working on a big project, where we use ant extensively. We pushed the limits of almost all the available components, found several issues, enhanced it in our custom wrappers. In that time, I was going through the sources of components several times, not only of the ant itself but also through sources of react-components on which the ant is built.
YET I HAVEN'T EVER INSPECTED THE BUTTON COMPONENT. Would be super funny if I would have found that christmas egg this summer...
Now as I'm thinking about it, we have EnhancedButton, which gets 'block' boolean prop to make it full-width. I was used to that from react-bootstrap and even had the idea to open feature request on antd... In that case I would certainly open the button.tsx...
Anyway, great episode in the frontend world.
My response to this little fiasco: why is anyone relying on externally-hosted, malleable code in a production environment? Run a repo, package it with your app ... whatever it takes to have a stable release.