Re:Statement on NPM Package Vulnerability in v5.0.2-5.1.0 of...
by jbaiter on Tuesday November 27, 2018 @11:18AM
(#18543592)
Funny thing is: They did actually lock down the version numbers of dependencies, they just didn't bother to check the updated dependencies: https://github.com/bitpay/copay/commit/6cc4b757f6fbd111b9716...
Re:Statement on NPM Package Vulnerability in v5.0.2-5.1.0 of...
by nepeckman on Tuesday November 27, 2018 @11:17AM
(#18543587)
> The fact that bitpay didn't lock down their version numbers of dependencies, and are thus at the whim of whatever changes upstream of them are gleefully picked up, is crazy, especially for a crypto wallet.
Would that have helped though? This dependency was several layers down, not a direct dependency of copay. I'm under the impression that even if bitpay locked their direct dependency, if that dependency auto updates _its_ dependencies, the result is the same.
Re:Statement on NPM Package Vulnerability in v5.0.2-5.1.0 of...
by javagram on Tuesday November 27, 2018 @11:19AM
(#18543613)
That’s not correct anymore.
NPM has a file called “package-lock.json” which locks all dependencies including dependencies of dependencies and so on.
Re:Statement on NPM Package Vulnerability in v5.0.2-5.1.0 of...
by dmortin on Tuesday November 27, 2018 @11:53AM
(#18543964)
> The fact that bitpay didn't lock down their version numbers of dependencies, and are thus at the whim of whatever changes upstream of them are gleefully picked up, is crazy, especially for a crypto wallet.
What it they lock down a version with compromised code in it well before it is discovered?
Locking down does not help if checkins are not scrutinized for malicious code.
Back in the early 00s I worked on a software build system (Java) that had to be able to guarantee reproducibility of past versions of builds for code escrow purposes, and to do that it needed to be able to run builds without a live internet connection to ensure we didn't have unintended external dependencies.
The fact that bitpay didn't lock down their version numbers of dependencies, and are thus at the whim of whatever changes upstream of them are gleefully picked up, is crazy, especially for a crypto wallet.