News for hackers. Stuff that matters.

A comment on Bitwarden Completes Third-Party Security Audit. Parent comment

Re:Bitwarden Completes Third-Party Security Audit by CiPHPerCoder on Monday November 12, 2018 @04:53PM (#18436247)
I haven't traced through the app's code to verify that is true.

Recommendation: If there is no HMAC tag with a ciphertext, immediately throw an exception. It makes it clearer that a decryption failure occurred (thus avoiding false positives).

[ Parent | on HN ]
Re:Bitwarden Completes Third-Party Security Audit by xxkylexx on Monday November 12, 2018 @05:14PM (#18436447)
It does do this [1], however, it is a little more complex since Bitwarden has to backwards-compat support old data that was AES-CBC encrypted from long ago before auth checks were implemented, while also combating against downgrade attacks. This same discussion was had back in January when you (I assume this is PIE Scott) reported the problem in issue 306171 on HackerOne which was closed out.

[1]: https://github.com/bitwarden/jslib/blob/master/src/services/...

[ Parent | on HN ]
Re:Bitwarden Completes Third-Party Security Audit by CiPHPerCoder on Monday November 12, 2018 @05:17PM (#18436474)
Oh, this did seem familiar!

The AES-CBC thing is tied to the key, right? So the downgrade attack isn't possible.

[ Parent | on HN ]
Re:Bitwarden Completes Third-Party Security Audit by xxkylexx on Monday November 12, 2018 @05:21PM (#18436502)
Yes, new account keys are identified (presence of a mac key) and block the downgrade (see code link above).
[ Parent | on HN ]