News for hackers. Stuff that matters.
Re:Show HN: Affinity.js – A simple view component library wi... by whyonearth on Wednesday November 07, 2018 @02:10PM (#18401397)
Feedback:

1. Parser prohibits literal "@click", there is no escape mechanism.

2. Only click, what about other DOM events?

3. Leaking: Event listeners not removed in destructor (your clean() function?)

4. No XSS protection, ow.

5. No tests, might want some.

6. Based on innerHTML assignment with nothing to guarantee valid HTML.

7. No error handling.

Re:Show HN: Affinity.js – A simple view component library wi... by orizens on Thursday November 08, 2018 @08:46AM (#18406173)
1. '@click' is replaced with a valid 'data-af-click' attribubte.

2. click was a poc - all events are added.

3. 'clean' is using "node.remove" ad removes any references to functions - so - no detached references are left then.

4. correct - not taken into consideration at the moment.

5. agree.

6. innerHTML is a valid assignment - the browser validates it.

7. to be discussed

Re:Show HN: Affinity.js – A simple view component library wi... by whyonearth on Thursday November 08, 2018 @11:46AM (#18407587)
I think you're being somewhat defensive of what appears to be a prototype, just offering the feedback you requested.

1. What I mean is that <span>@code</span> becomes <span>data-af-click</span>.

2. Where? Not seeing them.

3. You're mistaken about event handler cleanup: https://dom.spec.whatwg.org/#dom-childnode-remove

6. My point here is that relying on strings is brittle. HTML builders, declarative APIs like JSX/React.createElement, and template-based approaches (where the template is a DOM node) are more robust.

Re:Show HN: Affinity.js – A simple view component library wi... by BrandoElFollito on Saturday November 10, 2018 @03:48AM (#18420512)
This is probably obvious, but just in case : for point 4 this is DOM-based XSS protection that is missing.
Re:Show HN: Affinity.js – A simple view component library wi... by orizens on Friday November 09, 2018 @08:56PM (#18419509)
added a more robust and better event listeners handling - which prevent leaking completely.