And keep in mind that sales are spread across that 2 year lifecycle - plenty of people buying the phone one year after its out, and then getting only another year of updates.

This is what happened to me when I bought a Nexus 5, and it was the final straw. I bought a cheap second hand iPhone 6S, and havn't looked back. I do miss the notification LED though, and the better clock/alarm functionality on Android.