Re:Confessions of a programmer: I hate code review (2010)
by onion2k on Monday October 29, 2018 @03:37AM
(#18325633)
Surely the resulting code is better than the original code (otherwise I'd expect the author to push back on the comments instead of implementing bad suggestion).
Only if the author cares enough about the code. I've implemented things I know are bad in the past because the politics of pushing back aren't worthwhile. Especially if you work in an environment where your review is driven by the opinion of your colleagues (eg stack ranking).
"Code reviews are painful" are often a sign of bad team dynamics or a culture of politically motivated decisions.
Only if the author cares enough about the code. I've implemented things I know are bad in the past because the politics of pushing back aren't worthwhile. Especially if you work in an environment where your review is driven by the opinion of your colleagues (eg stack ranking).
"Code reviews are painful" are often a sign of bad team dynamics or a culture of politically motivated decisions.