Re:Rust RAII is better than the Haskell bracket pattern
by dbaupp on Tuesday October 09, 2018 @06:44AM
(#18174784)
If there's a cycle of strong references with Rc or Arc (or shared_ptr in C++), those objects still never get dropped/have their destructors called.
[ Parent
| on HN ]
Re:Rust RAII is better than the Haskell bracket pattern
by zaphar on Tuesday October 09, 2018 @12:45PM
(#18177501)
Rc's drop will be called. But whether the exposed object's drop will be called is dependent on the reference count.
But Rc would not work if the drop was not guaranteed to be called.
Re:Rust RAII is better than the Haskell bracket pattern
by dbaupp on Tuesday October 09, 2018 @05:00PM
(#18179770)
I was a little unclear but that is of course what I meant: talking about the underlying shared data because the pointers themselves don't have particularly interesting destruction behaviour. (Although the sibling is also correct that not all Rc/Arc/shared_ptr handles to the shared data with have their Drop called.)
Re:Rust RAII is better than the Haskell bracket pattern
by steveklabnik on Tuesday October 09, 2018 @12:53PM
(#18177591)
If you have a reference cycle, the two Rcs will keep each other alive, and their Drops will not be called.
Re:Rust RAII is better than the Haskell bracket pattern
by quietbritishjim on Tuesday October 09, 2018 @12:43PM
(#18177482)
I think that falls into the category I mentioned in the third paragraph of my comment: a serious pre-existing bug with other consequences will potentially cause the guarantee to be violated. A similar effect would happen if you had a double free that sometimes caused a crash, which is a similar level of programming mistake to creating a cyclic reference. To me it sits outside of a reasonable definition of "guaranteed".
Re:Rust RAII is better than the Haskell bracket pattern
by dbaupp on Tuesday October 09, 2018 @04:58PM
(#18179759)
No, typically, a reference cycle is fine. It results in valid memory that never gets read again, which is unfortunate but not dangerous, whereas double-frees can result in memory corruption. http://huonw.github.io/blog/2016/04/memory-leaks-are-memory-...