News for hackers. Stuff that matters.
Re:Becoming a Better Software Developer: A Handbook on Perso... by nine_k on Thursday September 20, 2018 @02:13PM (#18034425)
Hmm. I suppose your CI and code review tools allow code on branches different than master?

So you can directly use them to show a what-if PR. I did; it worked, that is, sparked a discussion and led us to designing things in a better way.

Re:Becoming a Better Software Developer: A Handbook on Perso... by derefr on Thursday September 20, 2018 @02:24PM (#18034487)
Yeah, I was picturing GitLab's CI/CD workflow here, where the RFC objects would get Review Apps built from them.

My objection to using PRs for this is that people think the point of a PR is to merge the code, and people tend to nitpick the code during code-review with the goal of making it clean enough to merge.

The idea of a separate RFC object is that, unlike a PR, you literally cannot merge an RFC, so there's no temptation to nitpick, or really to talk about anything other than the design. It much more closely mimics the social mores of a mailing-list thread discussing a code snippet.

Also, being able to explicitly track Approved and Rejected RFCs on a system level would be nice, to know what discussion needs to be referenced when doing the final implementation. If you just used "what-if" PRs, both the chosen and not-chosen designs' PRs would just end up in the Closed state, and would show up equally in search. Ideally, Rejected RFCs would be filtered out of search by default.

Re:Becoming a Better Software Developer: A Handbook on Perso... by jl-gitlab on Thursday September 20, 2018 @02:34PM (#18034544)
Interesting idea. We already sort of have a special-case MR (WIP) where merge is disabled until the work-in-progress status is removed. It could be interesting to have an RFC equivalent where no merge is clearly ever intended, but you still get the conversation flow, review app, and so on.
Re:Becoming a Better Software Developer: A Handbook on Perso... by Serow225 on Friday September 21, 2018 @12:52AM (#18037231)
Definitely might be useful for teams/projects organized enough to have an RFC process.