I agree it was a shock to the system in the short term, and that it wasn’t as effective as everyone expected it to be. But it has certainly brought many many people into the tax fold. This means better tax compliance and more money available for infra.
Bringing people into the tax fold means nothing if most people are added to the bottom tier where they pay nothing or very little tax. The IT department does not have the resources to audit and pursue everyone who filed nominal taxes in the financial year following demonetisation and is now reporting income below the taxable threshold.
And growth in actual direct tax collection this year up to July 31 has been dismal.
https://www.business-standard.com/article/economy-policy/dir...
We'll soon see what the extension up to August 31 netted. Unless there is a miraculous jump in collections in August, the entire 'we ended up collecting more income tax because of demonetisation' shtick will have fallen flat.
Your anecdotal accounts of people getting paid in advance count for nothing against the millions of people who didn't get paid for past work and the millions of people who didn't get work that was scheduled to happen because nobody could pay. Markets were deserted, no goods were selling. This shit went on for months. Everybody who actually lived in India during the time saw this happen.