I've been thinking about this a lot lately. Many jobs seem to have a net negative value for society - soda, highly processed food, credit cards, car dealerships, (most) sales people, etc. We'd probably be better of as a society paying these people to do nothing than to do what they do now; we'd be even better off if we paid them to do something actually productive. There might not be a perfect solution for this problem, but we don't seem interested in having a discussion about any solution to it.
Like you said, we have a curious moral framework at play here. For instance, a highly paid person who has a job with a net negative impact on society is often considered more moral than a beggar on the street (and it should be noted that the former is going to be consuming more resources from society as well). Because most people will calculate someone's worth by having a job, not by judging its impact on society (at least, most of the time).
More than that, we also have very peculiar standards between jobs. I like to pick on marketing/advertising, because I'm absolutely baffled by it. Somehow the profession that often dabbles in lying, scamming and generally making other people's lives worse off (by dragging them towards suboptimal choices) became a respectable occupation, even though if a typical salesman applied their skills to their friends and family, he'd eventually end up punched in the face. It's not even an issue of impact on society at large - we've legitimized, and even glorified, acting maliciously towards random strangers.
People marvel at how successful the greedy optimization algorithm of our economy is at finding local optima, but when you take a step back the emperor has no clothes. Sigh.
Rubbish.
Soda taste great, I love it. Don't tell me what is 'good or bad for me' - I can figure that out.
'Processed Foods' feed the world. They're not fundamentally unhealthy, can can absolutely be part of a decent diet.
Credit Cards - are an amazing financial innovation. Consumer credit is a really big deal that helps grease the wheels. Wherever there is no good consumer credit system - the economy is crap.
Car Dealerships and Salespeople - they definitely serve a function and it's why they are among the highest paid. Most people still like to test cars. The car industry relies on the model of dealerships and Tesla riding without is just like a new airline entrant just running only the profitable routes, and not carrying the longer tail ones. Also society has changed a little bit so admittedly the model could adapt.
All of those thinks you mentioned could be improved, and can be risky, but without them we'd be much worse off.
It did not happen when some countries switched to much more strict advertising rules.
People don't stop eating, drinking and buying medicines. Or start saving money that will never be spent.
Coke vs Pepsi is much less of a thing than the constant reinforcement that you would really, really enjoy one or the other right now. The constant reinforcement drives absolute sales, not just relative market share.
I think the problem is more that a lot of heavily advertised products are incredibly harmful to personal and environmental health. Sugar is unbelievably toxic over the longer term (weight gain, diabetes, etc) but the canonisation of the profit motive means that market morality rewards the creation and promotion of these toxic effects.
You could argue that if people want to poison themselves they should be allowed to. But even ignoring the direct social costs of the medical care required to clean up the effects of Type II diabetes and heart disease, the argument is patchily applied.
Some poisons (sugar, alcohol, tobacco) get a pass, while others (psychedelic drugs) don't. A few like cocaine remain in limbo, with nominal disapproval but tacit - and sometimes not so tacit - covert political support.
It's not just about bullshit jobs but about bullshit consumption, and the curious moral frameworks that support it.